Fix bug (missing commit) + SA2.0 usage in model.Job.update_hdca_update_time_for_job #16777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing a commit statement: with
autocommit=False
ifskip_locked
is supportedsa_session.execute(implicit_statement)
will be rolled back. (unless it's committed later, which we shouldn't rely upon).In fact, i wonder whether we shouldn't just use a connection here instead of the session (we are in the
else
clause). but, in any case, the commit was missing.(pulled out of #16724 for convenience)
Ref #12541
UPDATE: nope, this doesn't work. Maybe try a connection instead...
How to test the changes?
(Select all options that apply)
License